PERFORCE change 143142 for review

Hans Petter Selasky hselasky at FreeBSD.org
Mon Jun 9 01:37:51 UTC 2008


http://perforce.freebsd.org/chv.cgi?CH=143142

Change 143142 by hselasky at hselasky_laptop001 on 2008/06/09 01:37:00

	
	USB cache sync bugfix.
	
	After countless hours of debugging I finally saw the
	light why the OHCI did not work on ARM. I had switched
	flush and invalidate on the SETUP packet! Grrr. Now
	it finally works like it should!

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#126 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#126 (text+ko) ====

@@ -1990,9 +1990,11 @@
 	    xfer->flags_int.control_hdr) {
 		/* special case */
 		if (xfer->flags_int.usb_mode == USB_MODE_DEVICE) {
+			/* The device controller writes to memory */
+			xfer->frbuffers[0].isread = 1;
+		} else {
+			/* The host controller reads from memory */
 			xfer->frbuffers[0].isread = 0;
-		} else {
-			xfer->frbuffers[0].isread = 1;
 		}
 	} else {
 		/* default case */


More information about the p4-projects mailing list