PERFORCE change 146209 for review

[Max Khon]

Hello!

Gábor Kövesdán wrote:

>>> http://perforce.freebsd.org/chv.cgi?CH=146209
>>>
>>> Change 146209 by gabor at gabor_server on 2008/07/29 16:01:05
>>>
>>>     - Just handle some command line options as noop.  They seem to be
>>>       rarely used based on the resources describing them.  From now on
>>>       let's concentrate on the really practical features instead of
>>>       these ones.
>>
>> I don't think it's a good idea to "implement" options as NOPs unless 
>> they really are NOPs.  This will just cause silent failure and/or 
>> script misbehaviour, which may be very hard to track down.
> I've been also thinking of this, and I'm still a bit unsure. It would be 
> bad if scripts failed due to this, but it would be also bad if scripts 
> didn't run because of a e.g. --side-by-side argument, which rarely (or 
> never?) makes any difference. I've played with the options a bit and a 
> lot of them made no difference in the output neither with normal diff 
> nor with context diff nor with unified diff. Maybe the best way to 
> investigate what are they for would be to dig deeply in the GNU code, 
> which is a mess. I haven't even found info about them on Google, thus I 
> don't think they worth the effort.

I think that you should not implement options as NOPs unless they are 
really NOPs too.

/fjoe