PERFORCE change 144741 for review

[Marcel Moolenaar]

On Jul 5, 2008, at 7:09 PM, Takahashi Yoshihiro wrote:

> In article <200807051943.m65JhHZ6066371 at repoman.freebsd.org>
> Marcel Moolenaar <marcel at freebsd.org> writes:
>
>> static struct isa_pnp_id isa_i8251_ids[] = {
>> 	{0x0100e4a5, "RSA-98III"},
>> 	{0}
>> };
>
>> 	/* Probe PnP _and_ non-PnP i8251 here. */
>> 	if (ISA_PNP_PROBE(parent, dev, isa_i8251_ids) != ENXIO) {
>> 		sc->sc_class = &uart_i8251_class;
>> 		return (uart_bus_probe(dev, 0, 0, 0, 0));
>> 	}
>
> These are wrong.  RSA98-III is based on ns8250 and has extended FIFO
> buffer.  So I think that the uart_rsa_class should be added.

Oh. In your patch you define it as i8251. I only refactored
the code. Also, the ns8250 class already supports extended
FIFOs, so we don't need a separate class for that. I'll
change it...

> FYI, RSA series are not for pc98 only.
> RSA-PCI (PCI) and RSA-DVII (ISA) exist but not supported yet.

Ok, good to know. With the refactored code there's maximum
sharing, so UART will support them on other platforms as
well...

-- 
Marcel Moolenaar
xcllnt at mac.com