PERFORCE change 133092 for review

[John Birrell]

http://perforce.freebsd.org/chv.cgi?CH=133092

Change 133092 by jb at jb_freebsd1 on 2008/01/12 05:02:21

	Enforce the return values when lookup fails.

Affected files ...

.. //depot/projects/dtrace/src/lib/libdwarf/dwarf_attrval.c#3 edit

Differences ...

==== //depot/projects/dtrace/src/lib/libdwarf/dwarf_attrval.c#3 (text+ko) ====

@@ -80,6 +80,8 @@
 		return DWARF_E_ARGUMENT;
 	}
 
+	*valp = 0;
+
 	if ((av = dwarf_attrval_find(die, attr)) == NULL) {
 		DWARF_SET_ERROR(err, DWARF_E_NO_ENTRY);
 		ret = DWARF_E_NO_ENTRY;
@@ -114,8 +116,9 @@
 		return DWARF_E_ARGUMENT;
 	}
 
+	*strp = NULL;
+
 	if ((av = dwarf_attrval_find(die, attr)) == NULL) {
-		*strp = NULL;
 		DWARF_SET_ERROR(err, DWARF_E_NO_ENTRY);
 		ret = DWARF_E_NO_ENTRY;
 	} else {
@@ -152,6 +155,8 @@
 		return DWARF_E_ARGUMENT;
 	}
 
+	*valp = 0;
+
 	if ((av = dwarf_attrval_find(die, attr)) == NULL) {
 		DWARF_SET_ERROR(err, DWARF_E_NO_ENTRY);
 		ret = DWARF_E_NO_ENTRY;
@@ -187,6 +192,8 @@
 		return DWARF_E_ARGUMENT;
 	}
 
+	*valp = 0;
+
 	if ((av = dwarf_attrval_find(die, attr)) == NULL) {
 		DWARF_SET_ERROR(err, DWARF_E_NO_ENTRY);
 		ret = DWARF_E_NO_ENTRY;