PERFORCE change 129920 for review
Alfred Perlstein
alfred at freebsd.org
Sat Feb 2 04:13:03 PST 2008
* Hans Petter Selasky <hselasky at freebsd.org> [080201 23:18] wrote:
> On Saturday 02 February 2008, Alfred Perlstein wrote:
> > This change makes very little sense. If xfer->frbuffers is a bare
> > pointer, then why add 0 to it? Just pass xfer->frbuffers or use a
> > macro that explains what you are doing.
> >
>
> I can change those to a plain "xfer->frlengths". It was just a reminder for
> me, because some places we use "xfer->frlengths + 1" and "xfer->frbuffers +
> 1".
>
> I will write a script that converts all of those.
What does '+ 1' mean? Is it something special like a channel or something?
If so it should be a macro that's more descriptive.
--
- Alfred Perlstein
More information about the p4-projects
mailing list