PERFORCE change 154071 for review

Ed Schouten ed at FreeBSD.org
Thu Dec 4 12:36:04 PST 2008


http://perforce.freebsd.org/chv.cgi?CH=154071

Change 154071 by ed at ed_flippo on 2008/12/04 20:35:20

	Hummm... It seems the problem is a little more complex.
	
	We should not need to call mark_for_update() (reading the source
	code), but for some reason this causes the input not to be
	drawn.
	
	If we call mark_for_update(scp, cursor + 1), we get a
	spontaneous reboot later on, because scp->end is out of bounds
	then. Temporary hack: call mark_for_update(scp, cursor + 1)
	unless we're at the last cell on the display.

Affected files ...

.. //depot/projects/mpsafetty/sys/dev/syscons/scterm-teken.c#7 edit

Differences ...

==== //depot/projects/mpsafetty/sys/dev/syscons/scterm-teken.c#7 (text+ko) ====

@@ -273,7 +273,8 @@
 	p = sc_vtb_pointer(&scp->vtb, cursor);
 	sc_vtb_putchar(&scp->vtb, p, map[ch], scteken_attr(a));
 	mark_for_update(scp, cursor);
-	mark_for_update(scp, cursor + 1);
+	/* XXX: why? */
+	mark_for_update(scp, imin(cursor + 1, scp->xsize * scp->ysize - 1));
 }
 
 static void


More information about the p4-projects mailing list