PERFORCE change 146620 for review

[Edward Tomasz Napierala]

http://perforce.freebsd.org/chv.cgi?CH=146620

Change 146620 by trasz at trasz_traszkan on 2008/08/04 13:40:37

	Add check for ACL_READ_ACL, which apparently got lost somewhere.

Affected files ...

.. //depot/projects/soc2008/trasz_nfs4acl/TODO#27 edit
.. //depot/projects/soc2008/trasz_nfs4acl/sys/kern/vfs_acl.c#6 edit

Differences ...

==== //depot/projects/soc2008/trasz_nfs4acl/TODO#27 (text+ko) ====

@@ -5,6 +5,10 @@
 - Correctly handle the situation in which we can stat, but cannot
   read ACL, in ls(1).
 
+- Clean up #defines.  For example, make VREAD_NAMED_ATTRS equal
+  to ACL_READ_NAMED_ATTRS, so there is no need for translation
+  between the two in kern/subr_acl_nfs4.c.
+
 - Decide what to do with write vs append on regular files.
 
 - Either add or extend existing manual pages for new API routines:

==== //depot/projects/soc2008/trasz_nfs4acl/sys/kern/vfs_acl.c#6 (text+ko) ====

@@ -241,11 +241,14 @@
 	if (error != 0)
 		goto out;
 #endif
+	error = VOP_ACCESS(vp, VREAD_ACL, td->td_ucred, td);
+	if (error != 0)
+		goto out;
+
 	error = VOP_GETACL(vp, type_unold(type), &inkernelacl,
 	    td->td_ucred, td);
-#ifdef MAC
+
 out:
-#endif
 	VOP_UNLOCK(vp, 0);
 	if (error == 0)
 		error = copyout_acl(&inkernelacl, aclp, type);