PERFORCE change 146346 for review

Tim Kientzle kientzle at freebsd.org
Sat Aug 2 19:24:10 UTC 2008


Anselm Strauss wrote:
> http://perforce.freebsd.org/chv.cgi?CH=146346

> -	/* assertEqualInt(i4(p + 16), XXXX); */ /* CRC-32 */
> +	assertEqualInt(i4(p + 16), crc32(0, &data, sizeof(data))); /* CRC-32 */

This is a nice, straightforward way to test this functionality.
Good work.

It would be nice to change the test code to write the data
as two operations:  write the first 5 bytes, maybe, then
write the rest.  That would test the CRC code a little more
thoroughly.

Tim


More information about the p4-projects mailing list