PERFORCE change 115947 for review

John Baldwin jhb at FreeBSD.org
Thu Mar 15 21:49:13 UTC 2007


http://perforce.freebsd.org/chv.cgi?CH=115947

Change 115947 by jhb at jhb_mutex on 2007/03/15 21:48:56

	Don't leak socket fd's if we get a fault trying to copyout
	the values.  Need to write a test case before this goes into
	CVS.

Affected files ...

.. //depot/projects/smpng/sys/kern/uipc_syscalls.c#99 edit

Differences ...

==== //depot/projects/smpng/sys/kern/uipc_syscalls.c#99 (text+ko) ====

@@ -665,6 +665,8 @@
 	fp2->f_type = DTYPE_SOCKET;
 	FILE_UNLOCK(fp2);
 	error = copyout(sv, uap->rsv, 2 * sizeof (int));
+	if (error)
+		goto free4;
 	fdrop(fp1, td);
 	fdrop(fp2, td);
 	goto done2;


More information about the p4-projects mailing list