PERFORCE change 120788 for review

Rui Paulo rpaulo at fnop.net
Wed Jun 6 00:26:03 UTC 2007


At Sat, 02 Jun 2007 21:06:56 +0200,
Attilio Rao wrote:
> 
> Rui Paulo wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=120788
> > Change 120788 by rpaulo at rpaulo_epsilon on 2007/06/02 17:55:58
> > 	Add locking.
> > Affected files ...
> 
> Ah, but it seems you don't use a "fast" interrupt handler, so you
> should not use a spinlock... spinlocks should only be used in fast
> interrupt handlers, otherwise you bring up all the disvantages of the
> model...

Could you please comment on this?

If I'm not doing something wrong, I need to use spin locks on my
interrupt handler, or else witness_checkorder will complain with
"blockable sleep lock".

Note that I'm using FILTERs.

Thanks in advance.
--
Rui Paulo


More information about the p4-projects mailing list