PERFORCE change 130460 for review
Kip Macy
kmacy at FreeBSD.org
Fri Dec 7 21:20:53 PST 2007
http://perforce.freebsd.org/chv.cgi?CH=130460
Change 130460 by kmacy at kmacy:storage:toestack on 2007/12/08 05:20:40
reduce coalesce nsecs in INVARIANTS case
remove skip statement causing us to lose ctrl queue updates
Affected files ...
.. //depot/projects/toestack/sys/dev/cxgb/cxgb_sge.c#14 edit
Differences ...
==== //depot/projects/toestack/sys/dev/cxgb/cxgb_sge.c#14 (text+ko) ====
@@ -367,7 +367,7 @@
q->coalesce_nsecs = 50000;
} else {
#ifdef INVARIANTS
- q->coalesce_nsecs = 50000;
+ q->coalesce_nsecs = 20000;
#else
q->coalesce_nsecs = 5000;
#endif
@@ -1585,7 +1585,7 @@
if (__predict_false(ret)) {
if (ret == 1) {
mtx_unlock(&q->lock);
- printf("no desc available\n");
+ log(LOG_ERR, "no desc available\n");
return (ENOSPC);
}
@@ -1620,7 +1620,7 @@
struct sge_txq *q = &qs->txq[TXQ_CTRL];
adapter_t *adap = qs->port->adapter;
- printf("Restart_ctrlq\n");
+ log(LOG_WARNING, "Restart_ctrlq in_use=%d\n", q->in_use);
mtx_lock(&q->lock);
again: reclaim_completed_tx_imm(q);
@@ -2676,8 +2676,6 @@
if (desc_reclaimable(&qs->txq[TXQ_ETH]) > TX_START_MAX_DESC)
taskqueue_enqueue(qs->port->adapter->tq,
&qs->port->timer_reclaim_task);
-#else
- wakeup(qs);
#endif
}
@@ -2692,6 +2690,7 @@
credits = G_RSPD_TXQ1_CR(flags);
if (credits)
qs->txq[TXQ_OFLD].processed += credits;
+
}
static void
@@ -2780,8 +2779,6 @@
eop = 1;
rspq->imm_data++;
- goto skip;
-
#endif
} else if (r->len_cq) {
int drop_thresh = eth ? SGE_RX_DROP_THRES : 0;
@@ -2808,9 +2805,6 @@
DPRINTF("pure response\n");
rspq->pure_rsps++;
}
-#ifndef DISABLE_MBUF_IOVEC
- skip:
-#endif
if (flags & RSPD_CTRL_MASK) {
sleeping |= flags & RSPD_GTS_MASK;
handle_rsp_cntrl_info(qs, flags);
More information about the p4-projects
mailing list