PERFORCE change 107872 for review

Roman Divacky rdivacky at FreeBSD.org
Sat Oct 14 03:22:31 PDT 2006


http://perforce.freebsd.org/chv.cgi?CH=107872

Change 107872 by rdivacky at rdivacky_witten on 2006/10/14 10:22:29

	PROC_LOCK around the copying to p_comm.

Affected files ...

.. //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#8 edit

Differences ...

==== //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#8 (text+ko) ====

@@ -1569,8 +1569,9 @@
 			error = copyin(comm, (void *) args->arg2, LINUX_MAX_COMM_LEN-1);
 			if (error)
 			   	return (error);
-			/* XXX: no locking needed? */
+			PROC_LOCK(p);
 			strcpy(p->p_comm, comm);
+			PROC_UNLOCK(p);
 			break;
 		case LINUX_PR_GET_NAME:
 			error = copyout(&p->p_comm, (void *) args->arg2, MAXCOMLEN+1);


More information about the p4-projects mailing list