PERFORCE change 110128 for review

Olivier Houchard cognet at FreeBSD.org
Thu Nov 16 20:53:45 UTC 2006


http://perforce.freebsd.org/chv.cgi?CH=110128

Change 110128 by cognet at cognet on 2006/11/16 20:53:22

	Setup the ATA interrupt as active low. It makes the interrupt storm
	go away, and it still works with a CF card plugged in (and we still
	correctly get interrupts).

Affected files ...

.. //depot/projects/arm/src/sys/arm/xscale/ixp425/avila_ata.c#10 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/xscale/ixp425/avila_ata.c#10 (text+ko) ====

@@ -136,9 +136,12 @@
 	rman_set_bustag(&sc->sc_ata, &sc->sc_expbus_tag);
 	rman_set_bushandle(&sc->sc_ata, sc->sc_ioh);
 
-	/* interrupt is active high */
 	GPIO_CONF_WRITE_4(sa, IXP425_GPIO_GPOER, 
 	    GPIO_CONF_READ_4(sa, IXP425_GPIO_GPOER) | (1<<AVILA_IDE_GPIN));
+	/* interrupt is active low */
+	GPIO_CONF_WRITE_4(sa, GPIO_TYPE_REG(AVILA_IDE_GPIN),
+	    GPIO_CONF_READ_4(sa, GPIO_TYPE_REG(AVILA_IDE_GPIN) |
+	    GPIO_TYPE(AVILA_IDE_GPIN, GPIO_TYPE_ACT_LOW)));
 
 	/* clear ISR */
 	GPIO_CONF_WRITE_4(sa, IXP425_GPIO_GPISR, (1<<AVILA_IDE_GPIN));


More information about the p4-projects mailing list