PERFORCE change 92499 for review

John Baldwin jhb at freebsd.org
Tue Feb 28 11:52:40 PST 2006


On Monday 27 February 2006 19:37, Warner Losh wrote:
> http://perforce.freebsd.org/chv.cgi?CH=92499
> 
> Change 92499 by imp at imp_hammer on 2006/02/28 00:37:10
> 
> 	Make PIO interrupt fast...
> 
> Affected files ...
> 
> .. //depot/projects/arm/src/sys/arm/at91/at91_pio.c#5 edit
> 
> Differences ...
> 
> ==== //depot/projects/arm/src/sys/arm/at91/at91_pio.c#5 (text+ko) ====
> 
> @@ -124,7 +124,8 @@
>  	 * Activate the interrupt, but disable all interrupts in the hardware
>  	 */
>  	WR4(sc, PIO_IDR, 0xffffffff);
> -	err = bus_setup_intr(dev, sc->irq_res, INTR_TYPE_MISC | INTR_MPSAFE,
> +	err = bus_setup_intr(dev, sc->irq_res,
> +	    INTR_TYPE_MISC | INTR_MPSAFE | INTR_FAST,
>  	    at91_pio_intr, sc, &sc->intrhand);
>  	if (err) {
>  		AT91_PIO_LOCK_DESTROY(sc);
 
You don't need the MPSAFE flag then.  FAST handlers are required to be
MPSAFE and don't ever run under Giant.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org


More information about the p4-projects mailing list