PERFORCE change 79976 for review

Hajimu UMEMOTO ume at FreeBSD.org
Mon Jul 11 11:25:29 GMT 2005


Hi,

>>>>> On Mon, 11 Jul 2005 11:08:14 GMT
>>>>> soc-bushman <soc-bushman at FreeBSD.org> said:

soc-bushman> ==== //depot/projects/soc2005/nsswitch_cached/src/lib/libc/net/netdb_private.h#4 (text+ko) ====

soc-bushman> @@ -134,11 +134,11 @@
soc-bushman>  int getprotobyname_r(const char *, struct protoent *, struct protoent_data *);
soc-bushman>  int getprotobynumber_r(int, struct protoent *, struct protoent_data *);
soc-bushman>  int getprotoent_r(struct protoent *, struct protoent_data *);
soc-bushman> -int getservbyname_r(const char *, const char *, struct servent *,
soc-bushman> -	char *, size_t, struct servent **);
soc-bushman> -int getservbyport_r(int, const char *, struct servent *,
soc-bushman> -	char *, size_t, struct servent **);
soc-bushman> -int getservent_r(struct servent *, char *, size_t, struct servent **);
soc-bushman> +struct servent *getservbyname_r(const char *, const char *, struct servent *,
soc-bushman> +	char *, size_t);
soc-bushman> +struct servent *getservbyport_r(int, const char *, struct servent *,
soc-bushman> +	char *, size_t);
soc-bushman> +struct servent *getservent_r(struct servent *, char *, size_t);
soc-bushman>  void sethostent_r(int, struct hostent_data *);
soc-bushman>  void setnetent_r(int, struct netent_data *);
soc-bushman>  void setprotoent_r(int, struct protoent_data *);

Why did you need to change the return value of *_r() functions from
int to struct servent *.  Though *_r() are not exposed yet, these
should be int for consistensy with other platforms.  So, please don't
change them.

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume at mahoroba.org  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/


More information about the p4-projects mailing list