PERFORCE change 64073 for review

John Baldwin jhb at FreeBSD.org
Tue Nov 2 13:11:21 PST 2004


On Monday 01 November 2004 06:26 pm, Peter Wemm wrote:
> http://perforce.freebsd.org/chv.cgi?CH=64073
>
> Change 64073 by peter at peter_daintree on 2004/11/01 23:26:03
>
> 	whoops. need sched_lock around this.

You can probably #ifdef SMP this, btw.  Also, don't commit this until I get my 
Alpha SMP patch submitted, because on Alpha the BSP isn't always CPU 0 (yet).

> Affected files ...
>
> .. //depot/projects/hammer/sys/kern/kern_shutdown.c#29 edit
>
> Differences ...
>
> ==== //depot/projects/hammer/sys/kern/kern_shutdown.c#29 (text+ko) ====
>
> @@ -248,7 +248,9 @@
>  	static int first_buf_printf = 1;
>
>  	/* Do all shutdown processing on cpu0 */
> +	mtx_lock_spin(&sched_lock);
>  	sched_bind(curthread, 0);
> +	mtx_unlock_spin(&sched_lock);
>
>  	/* collect extra flags that shutdown_nice might have set */
>  	howto |= shutdown_howto;

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org


More information about the p4-projects mailing list