PERFORCE change 48556 for review

Marcel Moolenaar marcel at xcllnt.net
Wed Mar 10 08:15:47 PST 2004


On Wed, Mar 10, 2004 at 09:17:22AM +0100, Poul-Henning Kamp wrote:
> In message <200403100801.i2A810eC071863 at repoman.freebsd.org>, Marcel Moolenaar 
> >	Note that most #ifdef DDB instances have to be replaced
> >	with #ifdef DEBUG, because DDB is specific to a single
> >	back-end, not to having debugging support in general. A
> >	new option, GDB, has been added to add support for gdb.
> >	This has to be worked-out still.
> 
> #ifdef DEBUG is a singulary bad choice since much code have private
> use of that macro.

The point of using a define is to be able to get rid of the debugger
calls in production systems. It doesn't matter if DEBUG has private
meaning as long as it relates to having debugging code. Other than
that, anything else is fine too, as long as it's not DDB.

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel at xcllnt.net


More information about the p4-projects mailing list