PERFORCE change 48112 for review

[Peter Wemm]

On Thursday 04 March 2004 10:13 pm, David O'Brien wrote:
> On Wed, Mar 03, 2004 at 10:13:21PM -0800, Peter Wemm wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=48112
> >
> > Change 48112 by peter at peter_daintree on 2004/03/03 22:12:27
> >
> > 	Umm. VESA doesn't exist on amd64.  Sorry David.
>
> I know -- I still wanted as much of sys/i386/conf/NOTES enabled as
> made [*]sense.
>
> -- David
> [*] you might expand this as "semi-", "doesn't", or "".

The problem is that we have some entries in options.amd64 that have no 
backing code.  This stops config from detecting the error.  Its 
important that we don't silently accept options that don't do anything.

VESA and VESA_DEBUG merely cause an entry to be made in opt_vesa.h - but 
nothing ever #include's it.  Allowing config to silently accept it 
means that people will get POLA when they wonder why the heck the VESA 
driver isn't working when the options are in their kernel and it didn't 
fail to compile.  The fact that its not actually there is certainly a 
POLA violation.
-- 
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5