PERFORCE change 30348 for review

Dag-Erling Smorgrav des at FreeBSD.org
Thu May 1 14:11:50 PDT 2003


http://perforce.freebsd.org/chv.cgi?CH=30348

Change 30348 by des at des.at.des.thinksec.com on 2003/05/01 14:10:49

	Constify the return value from pam_getenv(3).  This violates XSSO,
	but I consider that a bug in the spec.

Affected files ...

.. //depot/projects/openpam/include/security/pam_appl.h#11 edit
.. //depot/projects/openpam/lib/pam_getenv.c#13 edit

Differences ...

==== //depot/projects/openpam/include/security/pam_appl.h#11 (text+ko) ====

@@ -31,7 +31,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $P4: //depot/projects/openpam/include/security/pam_appl.h#10 $
+ * $P4: //depot/projects/openpam/include/security/pam_appl.h#11 $
  */
 
 #ifndef _PAM_APPL_H_INCLUDED
@@ -83,7 +83,7 @@
 	const char **_user,
 	const char *_prompt);
 
-char *
+const char *
 pam_getenv(pam_handle_t *_pamh,
 	const char *_name);
 

==== //depot/projects/openpam/lib/pam_getenv.c#13 (text+ko) ====

@@ -31,7 +31,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $P4: //depot/projects/openpam/lib/pam_getenv.c#12 $
+ * $P4: //depot/projects/openpam/lib/pam_getenv.c#13 $
  */
 
 #include <stdlib.h>
@@ -48,7 +48,7 @@
  * Retrieve the value of a PAM environment variable
  */
 
-char *
+const char *
 pam_getenv(pam_handle_t *pamh,
 	const char *name)
 {


More information about the p4-projects mailing list