PERFORCE change 36551 for review

[John Baldwin]

On 21-Aug-2003 Marcel Moolenaar wrote:
> http://perforce.freebsd.org/chv.cgi?CH=36551
> 
> Change 36551 by marcel at marcel_nfs on 2003/08/21 00:30:38
> 
>       Aarrgghh. The interrupt issue on pluto1 and pluto2 are
>       very likely not driver problems. I forgot we have a hack
>       on the ia64 branch to deal with the fact that the non-
>       legacy interrupts used by the UARTs are edge sensitive,
>       active high. We really need to get that fixed in CVS...
> 
> Affected files ...
> 
> .. //depot/projects/uart/ia64/ia64/interrupt.c#4 edit
> 
> Differences ...
> 
> ==== //depot/projects/uart/ia64/ia64/interrupt.c#4 (text+ko) ====
> 
> @@ -266,9 +266,18 @@
>               struct sapic *sa = ia64_sapics[i];
>               if (irq < sa->sa_base || irq > sa->sa_limit)
>                       continue;
> +             /*
> +              * KLUDGE: Not all interrupts higher or equal to 16 are
> +              * active low and level sensitive. We don't know yet how
> +              * to check for this, so we hardcode the 2 cases we have
> +              * wrong explicitly. This kludge is specific to the HP
> +              * rx2600...
> +              */

Have you tried looking at any interrupt overrides in the MADT?
That is where the BIOS should tell you which interrupts above 15
have ISA-like parameters.

>               sapic_enable(sa, irq - sa->sa_base, vector,
> -                 (irq < 16) ? SAPIC_TRIGGER_EDGE : SAPIC_TRIGGER_LEVEL,
> -                 (irq < 16) ? SAPIC_POLARITY_HIGH : SAPIC_POLARITY_LOW);
> +                 ((irq < 16 || vector == 66 || vector == 67)
> +                     ? SAPIC_TRIGGER_EDGE : SAPIC_TRIGGER_LEVEL),
> +                 ((irq < 16 || vector == 66 || vector == 67)
> +                     ? SAPIC_POLARITY_HIGH : SAPIC_POLARITY_LOW));
>       }
>  }
>  

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/