PERFORCE change 28149 for review

[Peter Wemm]

John Baldwin wrote:
> 
> On 05-Apr-2003 Peter Wemm wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=28149
> > 
> > Change 28149 by peter at peter_overcee on 2003/04/04 19:32:58
> > 
> >       oops. s/l/q/ in write_rflags()
> > 
> > Affected files ...
> > 
> > .. //depot/projects/hammer/sys/x86_64/include/cpufunc.h#7 edit
> > 
> > Differences ...
> > 
> > ==== //depot/projects/hammer/sys/x86_64/include/cpufunc.h#7 (text+ko) ====
> > 
> > @@ -357,7 +357,7 @@
> >  static __inline void
> >  write_rflags(u_long ef)
> 
> On an unrelated topic:
> 
> A lot of these cpufunc things should use register_t rather than int
> or long.  This would have slightly simplified porting them to hammer
> and reduce the diffs.

Yes, I agree.  I intended to backport many of these things.  However,
a caveat.. Some of these entities are actually only 32 bits long, eg: the
cpuid stuff and some of the crX registers.. although you can read/write them
with a 64 bit register, they only have 32 valid bits.  I'll keep the
register_t in mind, I note that the critical* stuff uses it.

Cheers,
-Peter
--
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5