[Bug 250311] devel/glib20: lock getfsent() usage to fix x11-fm/thunar crashes

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250311

Tomasz Sowa <bugsfreebsd at ttmath.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugsfreebsd at ttmath.org

--- Comment #4 from Tomasz Sowa <bugsfreebsd at ttmath.org> ---
I have got a similar problem with x11-fm/caja:

#0  strlcpy (dst=0x7fffde9f2280 "\300\b \t\b", src=<optimized out>,
dsize=<optimized out>) at /disk2Tb/usr/src/lib/libc/string/strlcpy.c:39
39                              if ((*dst++ = *src++) == '\0')
[Current thread is 1 (LWP 100454)]
(gdb) bt
#0  strlcpy (dst=0x7fffde9f2280 "\300\b \t\b", src=<optimized out>,
dsize=<optimized out>) at /disk2Tb/usr/src/lib/libc/string/strlcpy.c:39
#1  0x00000008019bc50e in fstabscan () at
/disk2Tb/usr/src/lib/libc/gen/fstab.c:184
#2  0x00000008019bc20c in getfsent () at
/disk2Tb/usr/src/lib/libc/gen/fstab.c:227
#3  0x000000080161ec06 in _g_get_unix_mount_points () at
../gio/gunixmounts.c:1436
#4  0x000000080161eab8 in g_unix_mount_points_get (time_read=0x0) at
../gio/gunixmounts.c:1660
#5  0x000000080161edc9 in g_unix_mount_point_at (mount_path=0x8055a4fe0
"/disk4T", time_read=0x0) at ../gio/gunixmounts.c:1687
#6  0x00000008016b1754 in ignore_trash_mount (mount=0x808f2fe30) at
../gio/glocalfile.c:1789
#7  0x00000008016ac9cb in ignore_trash_path (topdir=0x8055a4f80 "/disk4T") at
../gio/glocalfile.c:1814
#8  0x00000008016ac74a in _g_local_file_has_trash_dir (dirname=0x80912f3e0
"/home/tomek/2/kopie", dir_dev=176) at ../gio/glocalfile.c:1850
#9  0x00000008016b2a8a in _g_local_file_info_get_parent_info (dir=0x80912f3e0
"/home/tomek/2/kopie", attribute_matcher=0x807a05ea0,
parent_info=0x7fffde9f2e28) at ../gio/glocalfileinfo.c:880
#10 0x00000008016ae2d5 in g_local_file_query_info
    (file=0x805d4c120, attributes=0x8072633c0
"standard::*,access::*,mountable::*,time::*,unix::*,owner::*,selinux::*,thumbnail::*,id::filesystem,trash::orig-path,trash::deletion-date,metadata::*",
flags=G_FILE_QUERY_INFO_NONE, cancellable=0x0, error=0x7fffde9f2f30) at
../gio/glocalfile.c:1217
#11 0x0000000801567c19 in g_file_query_info
    (file=0x805d4c120, attributes=0x8072633c0
"standard::*,access::*,mountable::*,time::*,unix::*,owner::*,selinux::*,thumbnail::*,id::filesystem,trash::orig-path,trash::deletion-date,metadata::*",
flags=G_FILE_QUERY_INFO_NONE, cancellable=0x0, error=0x7fffde9f2f30) at
../gio/gfile.c:1286
#12 0x0000000801575ccd in query_info_async_thread (task=0x8091551c0 [GTask],
object=0x805d4c120, task_data=0x807a4b9d0, cancellable=0x0) at
../gio/gfile.c:5534
#13 0x00000008015eb4d3 in g_task_thread_pool_thread (thread_data=0x8091551c0,
pool_data=0x0) at ../gio/gtask.c:1417
#14 0x000000080187b3c7 in g_thread_pool_thread_proxy (data=0x805581260) at
../glib/gthreadpool.c:354
#15 0x0000000801879a35 in g_thread_proxy (data=0x805c92800) at
../glib/gthread.c:820
#16 0x000000080143afec in thread_start (curthread=0x805ea0300) at
/disk2Tb/usr/src/lib/libthr/thread/thr_create.c:292
#17 0x0000000000000000 in  ()

The first patch fixed the problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.