[Bug 237714] [PATCH] sysutils/xfce4-power-manager: fix craches, improve freebsd support, add DEBUG option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237714

--- Comment #7 from Guido Falsi <madpilot at FreeBSD.org> ---
(In reply to rozhuk.im from comment #6)
> if (NULL != sleep_mode && !g_strcmp0 (sleep_mode, "Standby"))
> 
> was important, IMHO.
> Im not sure is g_strcmp0() check to NULL, and this was point of crash.

I forgot to mention that change in my description.

I removed that because AFAIK g_strcmp0() does check for NULL. [1]

Although, if you tell me you experienced crashes there I agree it's required,
so I'll add that back before committing.

> 
> I undestand that you dont like DEBUG option, but I dont know another way to
> build only some ports with debug and keep them with debug after portmaster
> upgrades.

My suggestion is to add the port origin to WITH_DEBUG_PORTS in make.conf like:

WITH_DEBUG_PORTS=   sysutils/xfce4-power-manager \
                    x11-fm/thunar

> You may not apply and not commit it, it is ok for me.

Thanks!


[1]
https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strcmp0

-- 
You are receiving this mail because:
You are the assignee for the bug.