[Bug 237714] [PATCH] sysutils/xfce4-power-manager: fix craches, improve freebsd support, add DEBUG option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237714

--- Comment #4 from Guido Falsi <madpilot at FreeBSD.org> ---
(In reply to Guido Falsi from comment #3)

> What I was criticizing is adding a "DEBUG" option using the options
> framework. It's better to only check for the WITH_DEBUG flag and act based
> on that, no need for an option in the option framework. Should every single
> port have a DEBUG option then?

Ti make this point clearer.

WITH_DEBUG should not be set by a port option, but should be manually set in
make.conf.

Some time ago I sent a review proposing to retire WITH_DEBUG and use a proper
silent option for that. I was discouraged, exactly for the same reasons I'm
stating I got convinced about that reasoning.

Rif: https://reviews.freebsd.org/D15773

-- 
You are receiving this mail because:
You are the assignee for the bug.