[Bug 236438] [PATCH] x11-fm/thunar: add debug option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236438

Guido Falsi <madpilot at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
                 CC|                            |madpilot at FreeBSD.org

--- Comment #2 from Guido Falsi <madpilot at FreeBSD.org> ---
Hi,

Thanks for the patch, I had a look. While I do agree with adding DEBUG support,
I think it should be done the "proper" way.

In the ports tree there is support for the "WITH_DEBUG" flag, which
automatically disables optimizations, adds the -g flag and disables stripping
of binaries(or at least tries to).

If a port needs further flags they should be linked to this flag.

I have also discovered that DEBUG options are not a good idea [1]

So I'd rework this patch to not add a DEBUG option to the port but use the
WITH_DEBUG (which is also triggere by WITH_DEBUG_PORTS) flag to check if extrra
options should be enabled.

I'd try to avoid a DEBUG option. Adding WITH_DEBUG_PORTS to make.conf is quite
easy.


[1] https://reviews.freebsd.org/D15773

-- 
You are receiving this mail because:
You are the assignee for the bug.