[Bug 222942] misc/xfce4-weather-plugin: Update to 0.8.10

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222942

            Bug ID: 222942
           Summary: misc/xfce4-weather-plugin: Update to 0.8.10
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch-ready
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: xfce at FreeBSD.org
          Reporter: duchateau.olivier at gmail.com
             Flags: maintainer-feedback?(xfce at FreeBSD.org)
          Assignee: xfce at FreeBSD.org

Created attachment 187091
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=187091&action=edit
Patch to update misc/xfce4-weather-plugin

- Update to 0.8.10
- Remove unneeded patch

Note: tested with xfce4-panel 4.13.1 (Gtk3 only) I noticed some icons
disappeared (since switch to Gtk3, icons in panel are loaded differently), so
in panel 4.12.x everythin should be fine.

Moreover in my 4.13 branch [1], I have patch, which fixes logical
GtkOrientation enum (previous releases are also affected):

weather.c:2035:31: warning: implicit conversion from enumeration type
'XfcePanelPluginMode' to different enumeration type 'GtkOrientation'
[-Wenum-conversion]
    data->panel_orientation = xfce_panel_plugin_get_mode(panel);
                            ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
weather.c:2038:34: warning: comparison of constant
'XFCE_PANEL_PLUGIN_MODE_DESKBAR' (2) with expression of type 'GtkOrientation'
is always false [-Wtautological-constant-out-of-range-compare]
        (data->panel_orientation == XFCE_PANEL_PLUGIN_MODE_DESKBAR &&
         ~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

As my patch is not yet review by upstream, and follow the FreeBSD Xfce team's
policy i'm waiting in order to propose my patch in the official ports tree.


[1]
https://app.assembla.com/spaces/xfce4/subversion/source/HEAD/tags/4.13/misc/xfce4-weather-plugin/files/patch-panel-plugin_weather.c

-- 
You are receiving this mail because:
You are the assignee for the bug.