[Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202192

Guido Falsi <madpilot at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |In Progress
                 CC|                            |madpilot at FreeBSD.org

--- Comment #3 from Guido Falsi <madpilot at FreeBSD.org> ---
Hi,

The GIO part of your patch seems to be already present in the newer upstream
code, even if the implementation is a little different there:

https://git.xfce.org/xfce/thunar/commit/thunar/thunar-sendto-model.c?id=1f5eed407c762bf7ca118e377f91c6cb1e63eb31

regarding the rest of your patch, you are removing some upstream logic and
replacing it with a very simplistic condition.

While I believe it works for your use case, I don't feel comfortable changing
it for all users in such a way without thorough testing, or at least a good
understanding of why the upstream had those more complex conditions.

I'll leave this open and try to study the source, time allowing, but it will
take some time to figure out. Also, I don't know sshfs, and maybe it's a very
specific thing.

BTW have you seen the wrong behavior without this patch appear in any other
filesystem besides sshfs?

-- 
You are receiving this mail because:
You are the assignee for the bug.