maintainer-approval requested: [Bug 250336] lang/clover: link failure after update to 20.2 : [Attachment 218735] [patch] avoid old ld(1) due to link problems on 11.x (at least)

[bugzilla-noreply at freebsd.org]

John Hein <jcfyecrayz at liamekaens.com> has asked freebsd-x11 (Nobody)
<x11 at FreeBSD.org> for maintainer-approval:
Bug 250336: lang/clover: link failure after update to 20.2
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250336

Attachment 218735: [patch] avoid old ld(1) due to link problems on 11.x (at
least)
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=218735&action=edit



--- Comment #1 from John Hein <jcfyecrayz at liamekaens.com> ---
Created attachment 218735
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=218735&action=edit
[patch] avoid old ld(1) due to link problems on 11.x (at least)

Use -fuse-ld=lld fixes this on 11.x

Note that this port already depends on (and uses) the ld from devel/binutils. 
With the change suggested here, it may be that the dependency on devel/binutils
is no longer necessary (including for other mesa ports).  I have not tried
using -fuse-ld=lld instead of USES=binutils in the larger graphics/mesa*
collection.  The patch here is just for lang/clover.

While here, address a couple portlint ordering warnings.

QA:
 - poudriere testport (ok)
 - portline (removes some warnings & no new warnings or errors)