[Bug 243649] [patch] devel/libepoll-shim: Update to 0.0.20191117 version to unbreak re-plugging input devices

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Jan 31 17:00:55 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243649

--- Comment #9 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 211221
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=211221
Patch to change libepoll-shim to use actual upstream, test targets, update to
20191117. Also some cleanup based on Jan's feedback

Looks good.

> +USES=		compiler:c11 cmake

Sort USES alphabetically. If unsure use ports-mgmt/portfmt then check the diff.

> +
> +USE_LDCONFIG=	yes
>  USE_GITHUB=	yes

Maybe drop newline after USES per bug 231422. However, if you do then a newline
before TEST_TARGET is also unnecessary.

(In reply to Michael Gmelin from comment #5)
> Unit tests 5 and 53 fail on i386, test 5 does so on purpose
> (it has a comment that it is lacking unit tests for archs != amd64).
> Test 53 would require some checking (also, this wasn't on native
> i386, but in a i386 build jail running on amd64).

At least running 32-bit Wayland clients on 64-bit compositor works fine.
Testing runtime on the oldest supported/alternative architecture (like 11.3
i386 atm) is part of my pre-commit menu e.g., for www/firefox.

Some tests seem to fail even on amd64 if run inside poudriere jail.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-x11 mailing list