Xorg (latest from ports) and no mouse movement

[Vladimir Kondratyev]

On 05.12.2020 19:10, Gary Jennejohn wrote:
> On Sat, 5 Dec 2020 16:45:00 +0300
> Vladimir Kondratyev <vladimir at kondratyev.su> wrote:
> 
>> On 05.12.2020 14:58, Matthias Apitz wrote:
>>> El d__a s__bado, diciembre 05, 2020 a las 12:43:54p. m. +0100, Matthias Apitz escribi__:
>>>   
>>>>
>>>> Hello,
>>>>
>>>> I'm setting up a new system on amd64 CURRENT (r368166) with ports from
>>>> November 30, compiled all with poudriere.
>>>>
>>>> The Xorg is started with 'startx' and .xserverrc has:
>>>>
>>>>   exec X -retro -logverbose 6
>>>>
>>>> and .xinitrc says only (to simplify the problem):
>>>>
>>>>   xterm -fn 10x20
>>>>
>>>> X11 comes up, starts the xterm but no mouse movement is working.
>>>>
>>>> Without X11 the mouse moves fine by the moused as:
>>>>
>>>> /usr/sbin/moused -p /dev/cyapa0 -t ps/2
>>>>
>>>> About the mouse the Xorg log has:  
>>>
>>> Additional information: attaching an USB mouse works fine, i.e. the
>>> problem is only with the touchpad.
>>>
>>> 	matthias
>>>   
>>>> root at c720-r368166:~ # grep mouse /var/log/Xorg.0.log
>>>> [  6260.470] (II) config/udev: Adding input device System mouse (/dev/input/event0)
>>>> [  6260.470] (**) System mouse: Applying InputClass "evdev pointer catchall"
>>>> [  6260.470] (**) System mouse: Applying InputClass "libinput pointer catchall"
>>>> [  6260.474] (II) Using input driver 'libinput' for 'System mouse'
>>>> [  6260.474] 	Option "name" "System mouse"
>>>> [  6260.475] (**) System mouse: always reports core events
>>>> [  6260.479] (II) event0  - System mouse: is tagged by udev as: Mouse
>>>> [  6260.479] (II) event0  - System mouse: device is a pointer
>>>> [  6260.480] (II) event0  - System mouse: device removed
>>>> [  6260.480] (II) XINPUT: Adding extended input device "System mouse" (type: MOUSE, id 6)
>>>> [  6260.481] (**) System mouse: (accel) selected scheme none/0
>>>> [  6260.481] (**) System mouse: (accel) acceleration factor: 2.000
>>>> [  6260.481] (**) System mouse: (accel) acceleration threshold: 4
>>>> [  6260.482] (II) event0  - System mouse: is tagged by udev as: Mouse
>>>> [  6260.482] (II) event0  - System mouse: device is a pointer
>>>> [  6278.765] (II) event0  - System mouse: device removed
>>>>
>>>> What is missing?
>>>>  
>> Try attached untested patch.
> 
> Shouldn't this line in the patch
> 
>  	/* Postpone start of the polling thread until sleep is available */
>  	if (config_intrhook_establish(&sc->intr_hook) != 0) {
> +		evdev_free(sc->evdev);
>  		mtx_destroy(&sc->mutex);
>  		return (ENOMEM);
>  	}
> 
> also have #ifdef EVDEV_SUPPORT .. #endif around it?
> 
Yes, it should.

Really, there are more wrong places in this quickly written piece of
code, е.g. missing division by zero check, but basically it should work.