[Bug 218811] graphics/libglapi: fails to build with bsdgrep
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Sat Apr 22 14:15:54 UTC 2017
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218811
Kyle Evans <bsdports at kyle-evans.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |emaste at freebsd.org
--- Comment #2 from Kyle Evans <bsdports at kyle-evans.net> ---
(In reply to Jan Beich from comment #1)
D'oh. This is a trivially broken case; easily exceeds the maximum number of
line matches (MAX_LINE_MATCHES=32), then it infinitely loops because it still
matches past that but it's not able to be inserted into 'matches,' causing my
failure mechanisms to fail because $bad.
I'll fix this in my -w empty broken review (https://reviews.freebsd.org/D10433)
version, because it's *not* straightforward to fix this on -HEAD since
procline() conflates matching a line with printing context. In the current
state of that patch, this will basically record 'st' and set lastmatches=0,
force a break at util.c:443, then at util.c:284 I'll throw in a loop that does
a procline() and printline() as long as we max out on matches.
Thanks for the report! =)
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the freebsd-x11
mailing list