ports/184952: x11-servers/xorg-server: Slave port makefiles all have same error

[John Marino]

The following reply was made to PR ports/184952; it has been noted by GNATS.

From: John Marino <freebsd.contact at marino.st>
To: Niclas Zeising <zeising at freebsd.org>
Cc: marino at freebsd.org, bug-followup at FreeBSD.org, freebsd at marino.st, 
 kwm at freebsd.org, Baptiste Daroussin <bapt at freebsd.org>
Subject: Re: ports/184952: x11-servers/xorg-server: Slave port makefiles all
 have same error
Date: Tue, 31 Dec 2013 22:33:03 +0100

 On 12/31/2013 21:17, Niclas Zeising wrote:
 > On 12/31/13 20:43, John Marino wrote:
 >> On 12/31/2013 19:23, Niclas Zeising wrote:
 >>> This breaks detection of WITH_NEW_XORG= and needs to be reverted.
 >>> Regards!
 >>
 >> Then your WITH_NEW_XORG detection is wrong.
 >> Having bsd.ports.options.mk loaded multiple times causes problems, such
 >> as applying the same patches multiple times (if patches are present).
 >> It was detected independently by myself and kwm.
 >>
 >> By the way, the "detection" broke DragonFly too because of the use of
 >> OSVERSION without OPSYS.
 >>
 >> I'd say the detection is what needs to be reverted.
 >>
 >> (DragonFly has /etc/defaults/make.conf so we put WITH_NEW_XORG defaults
 >> there)
 > 
 > 
 > FreeBSD has no such thing, so that is not an option. 
 
 Yes, I was surprised to discover this when I investigated earlier.
 
 > Currently WITH_NEW_XORG is defined in bsd.port.mk, which is included from
 > bsd.port.options.mk.  This needs to be included WITH_NEW_XORG is
 > checked.  Bapt said that the best way was to include bsd.port.options.mk
 > before checking for WITH_NEW_XORG.  I will leave this as-is for now,
 > since I'm not in a position to develop a better solution currently,
 > however, this has to be revisisted asap.
 
 If bsd.ports.options.mk is loaded at least once, why does removing it
 from xephry/nested/vbf slave ports break the detection?  Should not it
 still work since xorg-server loads it?
 
 John