PATCH: x11/libXdmcp needs USE_GNOME=pkgconfig

Robert Noland rnoland at FreeBSD.org
Mon Mar 8 11:10:25 UTC 2010


On Mon, 2010-03-08 at 10:45 +0100, Gerald Pfeifer wrote:
> Ping.  Here are some relevant lines from building this port:
> 
>   checking for pkg-config... /usr/local/bin/pkg-config
>   checking pkg-config is at least version 0.9.0... yes
> 
> Okay to commit?

NAK, This is already handled in bsd.xorg.mk.

. if ${XORG_CAT} == "lib"
USE_GNOME+=     gnomehack pkgconfig
USE_LDCONFIG=   yes
CONFIGURE_ARGS+=--enable-malloc0returnsnull
. endif

robert.

> Gerald @FreeBSD.org
> 
> On Mon, 15 Feb 2010, Gerald Pfeifer wrote:
> > I noticed that x11/libXdmcp uses pkg-config, but fails to set
> >   USE_GNOME=     pkgconfig
> > in its Makefile.
> > 
> > Unless this is intentional and I am missing something, do you
> > approve of the patch below?
> > 
> > Gerald @FreeBSD.org
> > 
> > 
> > Index: libXdmcp/Makefile
> > ===================================================================
> > RCS file: /home/pcvs/ports/x11/libXdmcp/Makefile,v
> > retrieving revision 1.15
> > diff -u -r1.15 Makefile
> > --- libXdmcp/Makefile	13 Mar 2008 10:33:54 -0000	1.15
> > +++ libXdmcp/Makefile	14 Feb 2010 23:51:00 -0000
> > @@ -15,5 +15,6 @@
> >  
> >  XORG_CAT=	lib
> >  USE_XORG=	xproto:both
> > +USE_GNOME=	pkgconfig
> >  
> >  .include <bsd.port.mk>
> _______________________________________________
> freebsd-x11 at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-x11
> To unsubscribe, send any mail to "freebsd-x11-unsubscribe at freebsd.org"
-- 
Robert Noland <rnoland at FreeBSD.org>
FreeBSD



More information about the freebsd-x11 mailing list