[Bug 210799] if_bwi broken

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210799

            Bug ID: 210799
           Summary: if_bwi broken
           Product: Base System
           Version: 10.3-RELEASE
          Hardware: ppc
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: wireless
          Assignee: freebsd-wireless at FreeBSD.org
          Reporter: josla972 at student.liu.se

After I upgraded from FreeBSD 9.0 to 10.3-RELEASE on my Mac Mini G4, I found
that "kldload if_bwi" would make the system unstable, and if I included it to
be loaded in loader.conf, I could not even boot. This used to work just fine.

Digging through the commits the bwi folder of the git clone of freebsd, I found
the issue:

commit ad311f67aaa6771c007f5046d032924146784a23
Author: mav <mav at FreeBSD.org>
Date:   Tue Apr 21 11:27:50 2015 +0000


    MFC r280347: Remove MAXBSIZE use from drivers where it has nothing to do.

    In some cases limits are just not needed, in others -- DFLTPHYS is the
    right constant to use instead.

diff --git a/sys/dev/bwi/if_bwi.c b/sys/dev/bwi/if_bwi.c
index 911e49e..6ce433c1 100644
--- a/sys/dev/bwi/if_bwi.c
+++ b/sys/dev/bwi/if_bwi.c
@@ -1915,7 +1915,7 @@ bwi_dma_alloc(struct bwi_softc *sc)
                               lowaddr,                 /* lowaddr */
                               BUS_SPACE_MAXADDR,       /* highaddr */
                               NULL, NULL,              /* filter, filterarg */
-                              MAXBSIZE,                /* maxsize */
+                              BUS_SPACE_MAXSIZE,       /* maxsize */
                               BUS_SPACE_UNRESTRICTED,  /* nsegments */
                               BUS_SPACE_MAXSIZE_32BIT, /* maxsegsize */
                               BUS_DMA_ALLOCNOW,        /* flags */



Reverting this commit made the system stable, if_bwi started working, and I
could boot again.

-- 
You are receiving this mail because:
You are the assignee for the bug.