[iwn] Review split 3

[Adrian Chadd]

Hi!

Cool! ok, the style niggles.

* Your #define IWN_blah needs a TAB between #define and the IWN_blah
value. Right now you have spaces.
* $FreeBSD$ should be after the copyright header, not before
* Your new file is missing the standard single-include stuff.. ie

#ifndef __IF_IWN_DEVID_H__
#define __IF_IWN_DEVID_H__

(header contents go here..)

#endif /* __IF_IWN_DEVID_H__ */



-adrian

On 29 July 2013 08:49, Cedric GROSS <cg at cgross.info> wrote:
> Hello,
>
>
>
> As discuss we Adrian, previous big patch is too heavy for direct application
> in repo.
>
> So I resume splitting modification.
>
>
>
> Here is split 3.
>
> This one create if_iwn_devif.h for storing device ID and subdevice ID for
> later use.
>
> If_iwn.c and If_iwnreg.h modified as needed.
>
>
>
> Cedric
>
>
> _______________________________________________
> freebsd-wireless at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-wireless
> To unsubscribe, send any mail to "freebsd-wireless-unsubscribe at freebsd.org"