[Differential] D10540: vmx: explicit checking for necessary invvpid/invept types

anish (Anish Gupta) phabric-noreply at FreeBSD.org
Sat Apr 29 04:41:37 UTC 2017


anish added inline comments.

INLINE COMMENTS

> ept.c:58-59
> +#define	INVVPID_REQUIRED_TYPES_MASK				\
> +	((1UL << (INVVPID_TYPE_SINGLE_CONTEXT + 40)) |	\
> +	(1UL << (INVVPID_TYPE_ALL_CONTEXTS + 40)))
> +#define	INVVPID_REQUIRED_TYPES_SUPPORTED(cap)	\

This is cryptic, better to have separate macros for it
#define  INVVPID_SINGLE_CTX_SUP(cap)      ((cap) & (1UL << 41))
#define  INVVPID_ALL_CTX_SUP(cap)             ((cap) & (1UL << 42))

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D10540

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: jan.dakinevich_gmail.com, grehan, neel
Cc: anish, imp, freebsd-virtualization-list


More information about the freebsd-virtualization mailing list