[Bug 234380] [snd_uaudio] Sample rate detection fails for SPL Crimson Rev 1

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234380

--- Comment #3 from Florian Walpen <dev at submerge.ch> ---
(In reply to commit-hook from comment #2)

Thanks, much appreciated.
I can confirm that this commit works as intended and fixes the issues with
sample rate detection on the Crimson. Unfortunately I cannot test it with my
other devices since they are all USB 1.1 only.

The code looks robust to me functionality-wise, I think both the fallback to
the old behavior (request ~255 bytes) and the support for longer tables are
good ideas, I didn't consider that in my patch.

Some comments if I may:
1. The comment for the fallback ("Likely the descriptor...") is confusing to
me. Isn't that the case for devices that either don't support a request for
only one row or don't support the request type at all?

2. Using the error code as a condition for the second request is a bit
misleading I think, wouldn't it be easier to just check for 'rates > 1'? That
would make the code shorter and the intention more understandable.

But these are minor issues, I'm happy with fixing it either way.

-- 
You are receiving this mail because:
You are the assignee for the bug.