USB/U3G: Added support for Panasonic CF-F9 GOBI 3G modem to U3G module

[Hans Petter Selasky]

On 10/01/17 19:09, Tomasz CEDRO wrote:
> On Sun, Oct 1, 2017 at 6:40 PM, Ian Lepore <ian at freebsd.org> wrote:
>> On Sun, 2017-10-01 at 18:33 +0200, Tomasz CEDRO wrote:
>>> On Wed, Sep 27, 2017 at 8:32 AM, Hans Petter Selasky <hps at selasky.org
>>>> wrote:
>>>>
>>>> On 09/27/17 00:37, Ian Lepore wrote:
>>>>>
>>>>>
>>>>> On Wed, 2017-09-27 at 00:30 +0200, Hans Petter Selasky wrote:
>>>>>>
>>>>>>
>>>>>> On 09/27/17 00:11, Tomasz CEDRO wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> https://github.com/freebsd/freebsd/pull/115
>>>>>>>
>>>>>>> :-)
>>>>>>>
>>>>>> The devd.conf rule should match more than just vendor and
>>>>>> product:
>>>>>>
>>>>>>
>>>>>> +# Load GOBI 2000/3000 U3G QDL modem firmware on attach / boot.
>>>>>> +# Note: This requires additional "gobi_loader" utility to be
>>>>>> installed,
>>>>>> +#   as well as valid QDL driver firmware files placed in
>>>>>> /boot/firmware/gobi.
>>>>>> +#   If modem does not accept valid firmware try gobi_loader
>>>>>> -2000
>>>>>> switch.
>>>>>> +#   Please adjust modem VID/PID to match your device supported
>>>>>> by
>>>>>> u3g
>>>>>> module.
>>>>>> +#attach 100 {
>>>>>> +#      match "vendor" "0x04da";
>>>>>> +#      match "product" "0x250e";
>>>>>> +#      action "/usr/local/sbin/gobi_loader /dev/cuaU0
>>>>>> /boot/firmware/gobi/";
>>>>>> +#};
>>>>>>
>>>>>> Else patch looks good.
>>>>>>
>>>>>> --HPS
>>>>>
>>>>> Hard-coding /dev/cuaU0 cannot possibly be right.
>>>>>
>>>>> -- Ian
>>>>>
>>>> These three lines are missing:
>>>>
>>>>          match "system"          "DEVFS";
>>>>          match "subsystem"       "CDEV";
>>>>          match "type"            "CREATE";
>>>>
>>>>
>>>> --HPS
>>> Thanks! Updated! :-)
>>>
>>> https://github.com/freebsd/freebsd/pull/115
>>>
>>
>> If this is to be an example, it should be correct.  Please replace the
>> "cuaU0" with "$cdev".  (See /etc/devd/uath.conf for an example).
>>
>> -- Ian
> 
> Thanks Ian! Is it okay now? I have moved this example to dedicated
> /etc/devd/u3g.conf file, and added u3g load to /etc/devd/usb.conf.. if
> syntax is okay I will verify on my laptop..
> 
> https://github.com/freebsd/freebsd/pull/115
> 

Looks good to me. Don't forget to MFC!

--HPS