usb/185628: usbd_req_re_enumerate set address failed USB_ERR_STALLED for Seagate USB drives between r259425 and r260321

[Alex Goncharov]

The following reply was made to PR usb/185628; it has been noted by GNATS.

From: Alex Goncharov <alex_goncharov_usa at yahoo.com>
To: FreeBSD-gnats-submit at FreeBSD.org, freebsd-usb at FreeBSD.org
Cc:  
Subject: Re: usb/185628: usbd_req_re_enumerate set address failed USB_ERR_STALLED for Seagate USB drives between r259425 and r260321
Date: Sat, 11 Jan 2014 03:10:41 -0800 (PST)

 No improvement after:
 
   * 'svn up' to r260531M
 
   * scsi_all.c reverted to:
 
 ----------------------------------------
 svn diff
 Index: sys/cam/scsi/scsi_all.c
 ===================================================================
 --- sys/cam/scsi/scsi_all.c     (revision 260531)
 +++ sys/cam/scsi/scsi_all.c     (working copy)
 @@ -6509,11 +6509,7 @@
                 while (rhs_id <= rhs_last
                     && (rhs_id->identifier + rhs_id->length) <= rhs_end) {
  
 -                       if ((rhs_id->id_type &
 -                            (SVPD_ID_ASSOC_MASK | SVPD_ID_TYPE_MASK)) ==
 -                           (lhs_id->id_type &
 -                            (SVPD_ID_ASSOC_MASK | SVPD_ID_TYPE_MASK))
 -                        && rhs_id->length == lhs_id->length
 +                       if (rhs_id->length == lhs_id->length
                          && memcmp(rhs_id->identifier, lhs_id->identifier,
                                    rhs_id->length) == 0)
                                 return (0);
 ----------------------------------------
 
 More info:
 
 ----------------------------------------
 sysctl kern.bootfile
 =>
 kern.bootfile: /boot/kernel/kernel
 
 strings /boot/kernel/kernel | grep '^FreeBSD 9'
 =>
 FreeBSD 9.2-STABLE #0 r260531M: Sat Jan 11 00:55:07 EST 2014
 
 ident /boot/kernel/kernel | grep sys/cam/scsi/scsi_all.c
 =>
      $FreeBSD: stable/9/sys/cam/scsi/scsi_all.c 257050 2013-10-24 10:34:13Z mav $
 
 ----------------------------------------
 
 With hw.usb.no_cs_fail 0 or 1, the same dmesges on attaching the
 Seagate drive:
 
 ----------------------------------------
 kernel: usbd_req_re_enumerate: addr=2, set address failed! (USB_ERR_STALLED, ignored)
 kernel: usbd_setup_device_desc: getting device descriptor at addr 2 failed, USB_ERR_STALLED
 kernel: usbd_req_re_enumerate: addr=2, set address failed! (USB_ERR_STALLED, ignored)
 kernel: usbd_setup_device_desc: getting device descriptor at addr 2 failed, USB_ERR_STALLED
 kernel: usb_alloc_device: Failure selecting configuration index 0:USB_ERR_STALLED, port 3, addr 2 (ignored)
 kernel: ugen5.2: <Seagate> at usbus5
 ----------------------------------------
 
 Used this drive all right yesterday with the build done 2013-12-15.
 
 -- Alex