usb/174963: buffalo wli-uc-gn wireless card sometimes unusable and emit "run0: wcid=xx out of range"

[jov]

>Number:         174963
>Category:       usb
>Synopsis:       buffalo wli-uc-gn wireless card sometimes unusable and emit "run0: wcid=xx out of range"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 04 05:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     jov
>Release:        9.1 release
>Organization:
>Environment:
fresh system,no custom kernel.but now I can't get it because I rebuild the kernel with the patch.
>Description:
I think the hardware is ok because I can use it in Win7. And in Freebsd 9.1,it works for sometime,but sometimes after system reboot or I plug out & plug in the card it my unusable.on the console it emmit:
 "run0: wcid=xx out of range" where xx is 91,87 and etc.

it seams the wifi is connected because ifconfig wlan0 cmd shows the right ssid and bssid ,but inet addr is always 0.0.0.0

>How-To-Repeat:
I plug out & plug in the card some times
>Fix:
thanks for PseudoCylon <moonlightakkiy at yahoo.ca>'s help, his patch solves the problem.

Reboot or re-plug-in shouldn't be a cause of the problem. Receiving an
association ID larger than device's max (64) is the problem. You must
be using a high-end AP. Reboot or re-plug-in initiate re-association
and just happen to receive a large association ID.


AK


--begin patch--

diff --git a/dev/usb/wlan/if_run.c b/dev/usb/wlan/if_run.c
index 3d2577f..ed11d97 100644
--- a/dev/usb/wlan/if_run.c
+++ b/dev/usb/wlan/if_run.c
@@ -2019,7 +2019,8 @@ run_key_set_cb(void *arg)
                wcid = 0;       /* NB: update WCID0 for group keys */
                base = RT2860_SKEY(RUN_VAP(vap)->rvp_id, k->wk_keyix);
        } else {
-               wcid = RUN_AID2WCID(associd);
+               wcid = (vap->iv_opmode == IEEE80211_M_STA) ?
+                   1 : RUN_AID2WCID(associd);
                base = RT2860_PKEY(wcid);
        }

@@ -2374,9 +2375,12 @@ run_newassoc(struct ieee80211_node *ni, int isnew)
        struct run_softc *sc = ic->ic_ifp->if_softc;
        uint8_t rate;
        uint8_t ridx;
-       uint8_t wcid = RUN_AID2WCID(ni->ni_associd);
+       uint8_t wcid;
        int i, j;

+       wcid = (vap->iv_opmode == IEEE80211_M_STA) ?
+           1 : RUN_AID2WCID(ni->ni_associd);
+
        if (wcid > RT2870_WCID_MAX) {
                device_printf(sc->sc_dev, "wcid=%d out of range\n", wcid);
                return;
@@ -3044,8 +3048,12 @@ run_tx(struct run_softc *sc, struct mbuf *m,
struct ieee80211_node *ni)
        txd->flags = qflags;
        txwi = (struct rt2860_txwi *)(txd + 1);
        txwi->xflags = xflags;
-       txwi->wcid = IEEE80211_IS_MULTICAST(wh->i_addr1) ?
-           0 : RUN_AID2WCID(ni->ni_associd);
+       if (IEEE80211_IS_MULTICAST(wh->i_addr1))
+               txwi->wcid = 0;
+       else {
+               txwi->wcid = (vap->iv_opmode == IEEE80211_M_STA) ?
+                   1 : RUN_AID2WCID(ni->ni_associd);
+       }
        /* clear leftover garbage bits */
        txwi->flags = 0;
        txwi->txop = 0;

>Release-Note:
>Audit-Trail:
>Unformatted: