usb/144199: commit references a PR
dfilter service
dfilter at FreeBSD.ORG
Thu Mar 11 21:50:03 UTC 2010
The following reply was made to PR usb/144199; it has been noted by GNATS.
From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:
Subject: Re: usb/144199: commit references a PR
Date: Thu, 11 Mar 2010 21:46:42 +0000 (UTC)
Author: thompsa
Date: Thu Mar 11 21:46:33 2010
New Revision: 205031
URL: http://svn.freebsd.org/changeset/base/205031
Log:
It appears that some UVISOR devices do not handle when the clear stall command
is issued at the beginning of the initial IN/OUT data transfers. Reason
unknown, probably firmware fault. Now the stall is only cleared on data
transfer errors.
PR: usb/144199
Submitted by: Hans Petter Selasky
Modified:
head/sys/dev/usb/serial/uvisor.c
Modified: head/sys/dev/usb/serial/uvisor.c
==============================================================================
--- head/sys/dev/usb/serial/uvisor.c Thu Mar 11 21:45:31 2010 (r205030)
+++ head/sys/dev/usb/serial/uvisor.c Thu Mar 11 21:46:33 2010 (r205031)
@@ -338,11 +338,6 @@ uvisor_attach(device_t dev)
DPRINTF("could not allocate all pipes\n");
goto detach;
}
- /* clear stall at first run */
- mtx_lock(&sc->sc_mtx);
- usbd_xfer_set_stall(sc->sc_xfer[UVISOR_BULK_DT_WR]);
- usbd_xfer_set_stall(sc->sc_xfer[UVISOR_BULK_DT_RD]);
- mtx_unlock(&sc->sc_mtx);
error = ucom_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
&uvisor_callback, &sc->sc_mtx);
_______________________________________________
svn-src-all at freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
More information about the freebsd-usb
mailing list