[patch] add usb hub (0x2514 / 0x0424) to usbdevs

[Alexander Best]

Hans Petter Selasky schrieb am 2010-03-11:
> On Thursday 11 March 2010 12:25:46 Alexander Best wrote:
> > just a product addition to usbdevs.

> > cheers.
> > alex

> > oh...and one question:


> Hi,

> See USB P4 ID 175574.

thanks. :)

> > why does `usbconfig dump_device_desc` say

> I think you need to compile the kernel with:

> option USB_VERBOSE

> Before it works like you expect.

options USB_VERBOSE seems broken on r204988:

cc -c -O0 -pipe -fno-builtin -march=native -std=c99 -g -Wall -Wredundant-decls
-Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith
-Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc
-I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL
-DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common
-finline-limit=8000 --param inline-unit-growth=100 --param
large-function-growth=1000  -fno-omit-frame-pointer -mcmodel=kernel
-mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow
-msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector
/usr/src/sys/dev/usb/usb_dev.c
cc -c -O0 -pipe -fno-builtin -march=native -std=c99 -g -Wall -Wredundant-decls
-Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith
-Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc
-I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL
-DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common
-finline-limit=8000 --param inline-unit-growth=100 --param
large-function-growth=1000  -fno-omit-frame-pointer -mcmodel=kernel
-mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow
-msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector
/usr/src/sys/dev/usb/usb_device.c
In file included from /usr/src/sys/dev/usb/usb_device.c:2181:
./usbdevs_data.h:5671: error: 'USB_VENDOR_MICRODIA' undeclared here (not in a
function)
*** Error code 1

Stop in /usr/obj/usr/src/sys/ARUNDEL.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.

> > although the vendor id is already in usbdevs?

> --HPS

i'd also like to ask what the purpose of this code in storage/umass.c is:

#define UMASS_EXT_BUFFER
#ifdef UMASS_EXT_BUFFER
/* this enables loading of virtual buffers into DMA */
#define UMASS_USB_FLAGS .ext_buffer=1,
#else
#define UMASS_USB_FLAGS
#endif

isn't that just doing the same as:

#define UMASS_EXT_BUFFER
/* this enables loading of virtual buffers into DMA */
#define UMASS_USB_FLAGS .ext_buffer=1,

cheers.
alex