usb4bsd patch review

[Warner Losh]

> On 2008-Aug-19 22:19:14 +0200, Hans Petter Selasky <hselasky at c2i.net> wrote:
> >On Tuesday 19 August 2008, Kris Kennaway wrote:
> >> Hans Petter Selasky wrote:
> >> > On Tuesday 19 August 2008, Alfred Perlstein wrote:
> >> >> need to wait for smp tty code.
> >> >
> >> > If this requires changes in the USB serial port drivers there will be
> >> > trouble.
> >>
> >> I am not sure what you mean by this statement, since it can be
> >> interpreted in several ways, some not so friendly.
> >
> >I mean I need to make another patchset. And that the current patchset will 
> >break the kernel compilation if blindly committed after mpsafetty.
> 
> I am concerned that the current plans appear to have both mpsafetty
> and usb4bsd committed at virtually the same time.  With the best will
> in the world, it's still likely that one or both imports will have
> some rough edges.  IMHO, there should be a reasonable period between
> major kernel subsystem upheavals to allow things to stabilise.  Having
> both a new USB stack and a new TTY subsystem would appear to make it
> unnecessarily difficult to identify the cause of USB serial port
> issues.

The new tty layer is in place now.  The new usb code likely is going
to have lots of issues, and the new tty code isn't likely going to be
any worse at obscuring them than other changes to the system that have
happened during the new usb code's development.

Warner