usb/78984: [umass] [patch] Creative MUVO umass failure

[Mark Kirkwood]

M. Warner Losh wrote:
> In message: <200804211030.m3LAU3Uo091913 at freefall.freebsd.org>
>             Mark Kirkwood <markir at paradise.net.nz> writes:
> : The following reply was made to PR usb/78984; it has been noted by GNATS.
> : 
> : From: Mark Kirkwood <markir at paradise.net.nz>
> : To: bug-followup at FreeBSD.org, bofh at m-wesemeyer.de
> : Cc:  
> : Subject: Re: usb/78984: [umass] [patch] Creative MUVO umass failure
> : Date: Mon, 21 Apr 2008 22:11:17 +1200
> : 
> :  I ran into this with 7-STABLE and a 128MB creatiev muvo. This slightly 
> :  updated patch seems to fix.
> :  ================================================================================
> :  *** sys/dev/usb/umass.c.orig    Mon Apr 21 18:17:08 2008
> :  --- sys/dev/usb/umass.c Mon Apr 21 18:20:31 2008
> :  ***************
> :  *** 374,379 ****
> :  --- 374,383 ----
> :        UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
> :        FORCE_SHORT_INQUIRY | NO_START_STOP | IGNORE_RESIDUE
> :      },
> :  +   { USB_VENDOR_CREATIVE, USB_PRODUCT_CREATIVE_NOMAD, RID_WILDCARD,
> :  +     UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
> :  +     READ_CAPACITY_OFFBY1
> :  +   },
> :      { USB_VENDOR_DESKNOTE, USB_PRODUCT_DESKNOTE_UCR_61S2B, RID_WILDCARD,
> :        UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
> :        NO_QUIRKS
> :  ================================================================================
>
> Are all Creative nomad's off by one?  In linux, this quirk is used
> extremely rarely, and i don't think I see the nomad on the lists...
>
>
>   

Good point, I think only the 128MB Nomad is the bad guy here - I guess I 
need to change RID_WILDCARD to whatever the id for the 128MB Nomad is (I 
see the original patch had 0x001 here) - assuming I've understood what 
RID_WILDCARD does correctly that is...

Cheers

Mark