ehci.c : uncommited patch fixes DRAC5 problems

[Hans Petter Selasky]

On Wednesday 20 September 2006 17:14, Bill Moran wrote:
> In response to Hans Petter Selasky <hselasky at c2i.net>:
> > Could you have checked if my new USB driver has the same problem?
> >
> > #
> > # First get all the sources
> > # (you need /usr/ports/devel/subversion installed)
> > #
> >
> > svn --username anonsvn --password anonsvn \
> >       checkout svn://svn.turbocat.net/i4b
> >
> > #
> > # The following commands will
> > # install the driver on FreeBSD:
> > #
> >
> > cd i4b/trunk/i4b/FreeBSD.usb
> > make S=../src package
> > make install
> >
> > #
> > # Then build a new kernel (with modules).
> > #
>
> [...]
> cc -pipe -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I-  
> -DHAVE_KERNEL_OPTION_HEADERS -include
> /usr/obj/usr/src/sys/GENERIC/opt_global.h -I. -I@ -I@/contrib/altq
> -I@/../include -finline-limit=8000 -fno-common -g -fno-omit-frame-pointer
> -I/usr/obj/usr/src/sys/GENERIC -mcmodel=kernel -mno-red-zone  -mfpmath=387
> -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float
> -fno-asynchronous-unwind-tables -ffreestanding -Wall -Wredundant-decls
> -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith
> -Winline -Wcast-qual  -fformat-extensions -std=c99 -c
> /usr/src/sys/modules/ucom/../../dev/usb/ucom.c
> /usr/src/sys/modules/ucom/../../dev/usb/ucom.c: In function `ucom_attach':
> /usr/src/sys/modules/ucom/../../dev/usb/ucom.c:186: error: `TS_CALLOUT'
> undeclared (first use in this function)
> /usr/src/sys/modules/ucom/../../dev/usb/ucom.c:186: error: (Each undeclared
> identifier is reported only once
> /usr/src/sys/modules/ucom/../../dev/usb/ucom.c:186: error: for each
> function it appears in.)
> /usr/src/sys/modules/ucom/../../dev/usb/ucom.c:186: warning: passing arg 3
> of `ttycreate' makes integer from pointer without a cast
> /usr/src/sys/modules/ucom/../../dev/usb/ucom.c:186: error: too few
> arguments to function `ttycreate' *** Error code 1
> 1 error

Ok. Just add:

#ifndef TS_CALLOUT
#define TS_CALLOUT MINOR_CALLOUT
#endif

If you get more errors, then just compile with the -k option to get all 
errors.

Before line 186.

> Note that I'm building an amd64 kernel.  Don't know if you've tested
> your code on that arch yet.

I have tested on AMD64, but I haven't tested FreeBSD 6.x recently. I currently 
use FreeBSD-7-current.

--HPS