usb/90081: QUIRK: Samsung usb key

[Henri-Pierre CHARLES]

>Number:         90081
>Category:       usb
>Synopsis:       QUIRK: Samsung usb key
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-usb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 07 18:10:01 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Henri-Pierre CHARLES
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
Université de Versailles
>Environment:
System: FreeBSD vlaminck.prism.uvsq.fr 5.4-STABLE FreeBSD 5.4-STABLE #4: Wed Dec 7 18:08:51 CET 2005 root at vlaminck.prism.uvsq.fr:/usr/obj/usr/src/sys/DELL i386

	An usb key is recognized, but it was impossible to mount it. Multiple
insert/removing cause a crash.  The key is a : "Samsung usb key 128Mb No other 
information on the key". Dmesg give <USB-DISK FreeDik-FlashUsb 1.06>

	tested on FreeBSD 5.4-RELEASE and 5.4-STABLE

>Description:

dmesg give after the insertion :

umass0: vendor 0x09a6 product 0x8001, rev 1.10/1.00, addr 2
da0 at umass-sim0 bus 0 target 0 lun 0
da0: <USB-DISK FreeDik-FlashUsb 1.06> Removable Direct Access SCSI-0 device 
da0: 1.000MB/s transfers
da0: Attempt to query device size failed: ILLEGAL REQUEST, Invalid field in CDB
umass0: Phase Error, residue = 0
(da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0


>How-To-Repeat:

	Multiple insert/Remove the key. Wait. Crash

>Fix:

	Apply this path seem to correct the problem :

vlaminck:scsi/>diff -c /tmp/scsi_da.c scsi_da.c
*** /tmp/scsi_da.c      Wed Dec  7 18:45:21 2005
--- scsi_da.c   Wed Dec  7 17:37:02 2005
***************
*** 27,33 ****
   */
  
  #include <sys/cdefs.h>
! __FBSDID("$FreeBSD: /repoman/r/ncvs/src/sys/cam/scsi/scsi_da.c,v 1.171.2.2 
2005/11/26 23:20:00 jdp Exp $");
  
  #ifdef _KERNEL
  #include "opt_hw_wdog.h"
--- 27,33 ----
   */
  
  #include <sys/cdefs.h>
! __FBSDID("$FreeBSD: src/sys/cam/scsi/scsi_da.c,v 1.171.2.2 2005/11/26 
23:20:00 jdp Exp $");
  
  #ifdef _KERNEL
  #include "opt_hw_wdog.h"
***************
*** 238,243 ****
--- 238,247 ----
                /*quirks*/ DA_Q_NO_SYNC_CACHE
        },
        /* USB mass storage devices supported by umass(4) */
+        {
+                 {T_DIRECT, SIP_MEDIA_REMOVABLE, "USB-DISK", 
"FreeDik-FlashUsb", "*"},
+                 /*quirks*/ DA_Q_NO_SYNC_CACHE
+         },
        {
                /*
                 * EXATELECOM (Sigmatel) i-Bead 100/105 USB Flash MP3 Player


After the patch :
vlaminck:~/>sudo usbdevs -v
Controller /dev/usb0:
addr 1: full speed, self powered, config 1, UHCI root hub(0x0000), Intel(0x0000), rev 1.00
 port 1 powered
 port 2 powered
Controller /dev/usb1:
addr 1: full speed, self powered, config 1, UHCI root hub(0x0000), Intel(0x0000), rev 1.00
 port 1 addr 2: low speed, power 70 mA, config 1, Dell USB Keyboard(0x2003), 
Dell(0x413c), rev 1.00
 port 2 addr 3: low speed, power 100 mA, config 1, product 0x3010(0x3010), Dell(0x413c), rev 2.20
Controller /dev/usb2:
addr 1: full speed, self powered, config 1, UHCI root hub(0x0000), Intel(0x0000), rev 1.00
 port 1 powered
 port 2 powered
Controller /dev/usb3:
addr 1: full speed, self powered, config 1, UHCI root hub(0x0000), Intel(0x0000), rev 1.00
 port 1 addr 2: full speed, self powered, config 1, product 0x0201(0x0201), Iiyama(0x04e1), rev 1.10
  port 1 powered
  port 2 powered
  port 3 powered
  port 4 addr 3: full speed, power 100 mA, config 1, product 0x8001(0x8001), vendor 0x09a6(0x09a6), rev 1.00
 port 2 powered

    * Output from dmesg for successful attach attempts (after quirk added)
umass0: vendor 0x09a6 product 0x8001, rev 1.10/1.00, addr 3
da0 at umass-sim0 bus 0 target 0 lun 0
da0: <USB-DISK FreeDik-FlashUsb 1.06> Removable Direct Access SCSI-0 device 
da0: 1.000MB/s transfers
da0: 127MB (262112 512 byte sectors: 64H 32S/T 127C)


>Release-Note:
>Audit-Trail:
>Unformatted: