Please commit fix outlined in PR/63837

Warner Losh imp at bsdimp.com
Fri Apr 8 12:42:33 PDT 2005


From: "Will Saxon" <WillS at housing.ufl.edu>
Subject: Please commit fix outlined in PR/63837
Date: Fri, 8 Apr 2005 15:34:14 -0400

> Is it possible to get the 1 line fix posted in PR/63837 added 
> before 5.4? This has been a problem since before 5.3, the fix is 
> trivial and it works fine.
> 
> It is kind of annoying to have to edit hid.c every time I cvsup.
> 
> This has been asked about before by myself and others... Is there
> a stylistic problem or a planned cleanup that has held this back?
> 
> --- /usr/src/sys/dev/usb/hid.c.orig  Fri Apr  8 15:26:46 2005
> +++ /usr/src/sys/dev/usb/hid.c       Fri Apr  8 14:55:01 2005
> @@ -375,7 +375,7 @@
> 
> 	id = 0;
> 	for (d = hid_start_parse(buf, len, 1<<k); hid_get_item(d, &h); )
> -		if (h.report_ID != 0)
> + 		if (h.report_ID != 0 && !id)
> 			id = h.report_ID;
> 	hid_end_parse(d);
> 	size = h.loc.pos;

So this patch just makes report_ID the FIRST id in the item list,
right?

Warner


More information about the freebsd-usb mailing list