Is this a programming error, or a compiler error..

[Willem Jan Withagen]

On 13-3-2019 13:17, Dimitry Andric wrote:
> On 13 Mar 2019, at 12:57, Willem Jan Withagen <wjw at digiware.nl> wrote:
>> I'm getting a crash in a Ceph test program in the following pice of code:
>>
>> struct entity_addrvec_t {
>>    vector<entity_addr_t> v;
>> .....
>>    entity_addr_t legacy_addr() const {
>>      for (auto& a : v) {
>>        if (a.type == entity_addr_t::TYPE_LEGACY) {
>>          return a;
>>        }
>>      }
>>      return entity_addr_t();
>>    }
>> ......
>>
>> Where the loop is taken, even if v.size() == 0
>> So v content is pointing to random memory and itterating over the next pointer results in a crash.
> This can happen when the vector is invalidated, due to either it, or its
> parent object having been moved from.  Maybe run this under valgrind or
> AddressSanitizer, that should give some more clues.

Would be new tricks for me... I'll look into it.
Prefixing the loop with `if (!empy())` fixes the runtime problem, and 
this is a single thread program
So there is no other thread here that could work on the vector and 
corrupt it while looping over it.

--WjW