[Bug 216080] science/bddsolve: fails to build with libc++ 4.0

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Jan 15 08:51:37 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216080

Jan Beich (mail not working) <jbeich at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |freebsd-toolchain at FreeBSD.o
                   |                            |rg

--- Comment #3 from Jan Beich (mail not working) <jbeich at FreeBSD.org> ---
>  bool exists_file(const std::string& filename)
>  {
>    std::ifstream from(filename.c_str());
> -  return (from);
> +  return !from.fail();

Why not "return from.good()" instead similar to textproc/libxml++26 upstream
fix? Otherwise, ask toolchain@ whether to convert or not. I don't know much
C++.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-toolchain mailing list