sys/dev/sound/pci/vibes.c bug? [was: Re: [current tinderbox] failure on ia64/ia64]

[Marcel Moolenaar]

On Thu, Mar 18, 2004 at 12:50:56PM +0100, Dag-Erling Sm?rgrav wrote:
> Marcel Moolenaar <marcel at xcllnt.net> writes:
> > The source code appears to be fishy. The variable v is never used.
> > It's only defined. If you change the "return mask" to a "return v",
> > the warning goes away.
> 
> I suspect that there's a line missing:
> 
> @@ -548,4 +548,5 @@
>         }
>         DEB(printf("sv_mix_setrecsrc: mask 0x%08x adc_input 0x%02x\n", mask, v));
> +       sv_indirect_set(sc, SV_REG_ADC_INPUT, v);
>         return mask;
>  }
> 
> although I have no way of testing this.

Me neither. If this is likely to be missing and we don't have a
maintainer for the code, I suggest we just commit it. The function
cannot be more wrong than it is without the change...

[Subject line changed to attract PCM maintainer(s)]

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel at xcllnt.net